Closed (fixed)
Project:
Content Synchronization
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Apr 2018 at 14:56 UTC
Updated:
3 Mar 2019 at 14:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
webfaqtory commentedComment #3
kfritscheFrom just looking at the code this should be easily fixable:
In src/Form/ContentExportTrait.php replace
with
and
with
Would be a good novice issue to create the patch here and test if this works.
Comment #4
kfritscheComment #5
Prabhu.shan commentedHi,
After doing the below changes as suggested,
In src/Form/ContentExportTrait.php replace
protected function generateSiteUUIDFile($data, &$context) {
with
public function generateSiteUUIDFile($data, &$context) {
and
protected function finishContentExportBatch($success, $results, $operations) {
with
public function finishContentExportBatch($success, $results, $operations) {
An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /batch?id=135&op=do_nojs&op=do
StatusText: OK
ResponseText: Error: Class 'Drupal\content_sync\Form\Yaml' not found in Drupal\content_sync\Form\ContentExportForm->generateSiteUUIDFile() (line 112 of /var/www/html/modules/contrib/content_sync/src/Form/ContentExportTrait.php).
Comment #6
ok-steve commentedI successfully made the changes. The errors from #5 were cause because the ContextExportTrait.php file didn't include the use statement for Yaml.
I didn't make the finishContentExportBatch method public because the problem was resolved without needing to.
Comment #7
Prabhu.shan commentedGreat.. Thanks for fixing.. Is it merged ? Can i download the dev version and check it out?
Comment #8
auxiliaryjoel commentedSccherry I tried to CLI your patch but I received this error:
can't find file to patch at input line 16
Perhaps you used the wrong -p or --strip option?
do you know what i'm doing wrong? the CLI I entered was:
curl https://www.drupal.org/files/issues/2018-06-07/content_sync-batch-export... | patch -p1
Comment #9
ok-steve commented@auxiliaryjoel Which directory are you in? When I ran your command in the Drupal root directory I saw the same error message you did, but when I ran the command from the content_sync directory it worked fine.
Comment #10
asirjacques commentedHi there,
@8auxiliaryjoel: I've been adding the patch into my composer.json
I can confirm the patch solve the issue and work as expected.
This should go into the next release.
Comment #11
blanca.esqueda commentedThank you for the patch,
I've reviewed it and included:
* Updated path for the finished batch callback.
* Removed some warnings happening on the finished callback.
* Specified the archive compress type.
I'll include the change on 8.x-2.x-dev and it will be on the next release.
Comment #13
blanca.esqueda commentedComment #14
blanca.esqueda commented