Convert array into short array.

CommentFileSizeAuthor
#3 basic.png161.26 KBakash.addweb
#2 2965857-2.patch8.76 KBVidushi Mehta

Comments

Vidushi Mehta created an issue. See original summary.

Vidushi Mehta’s picture

Status: Active » Needs review
StatusFileSize
new8.76 KB
akash.addweb’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new161.26 KB

@Vidushi Mehta, Your patch is working fine, I checked it with Pareview standards errors & attached the screenshot for the same.

joelpittet’s picture

These patches can be disruptive to other patches in the queue because they touch a lot of code. Typically they will force other bug fixes to get rerolled and if they get in first will cause this one to be rerolled. So this should only be committed right before a release.

leahtard’s picture

I tested the patch and all applied correctly. After applying the patch, I confirmed that I could still run `drush basic-install` successfully.

@joelpittet, the patch only makes changes to the drush install script. Is this still considered disruptive? I just finalized a new release today which didn't include any updates to this file.

Cheers, Leah

joelpittet’s picture

It's great to commit with a new release (right before or just after) to be the least disruptive to patches in the queue (there will likely be some that need to be rerolled regardlress of when this is applied).

Although if there are other parts of the code that need to be converted I'd do that here first.

leahtard’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

Thanks @joelpittet! Did a search through the code base and we don't have any other arrays in place. I'll get this one committed and a new release out later this week.

Cheers, Leah

joelpittet’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

Whoops didn't mean to change it without asking. Are you using patch to be ported for another purpose?

Vidushi Mehta’s picture

Oh Great guys! I also go through the code and only found the arrays in drush file. Its good if it's get committed with new release.
Thanks.

  • Vidushi Mehta authored 5853616 on 8.x-2.x
    Issue #2965857 by Vidushi Mehta, Ronak.addweb, joelpittet, leahtard: Use...
leahtard’s picture

Status: Reviewed & tested by the community » Fixed

Oops, I didn't mean to set it as to be ported. Thanks for fixing @joelpittet.

This patch has now been committed to the dev branch. I will release soon.

Cheers, Leah

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.