Convert array into short array.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | basic.png | 161.26 KB | akash.addweb |
| #2 | 2965857-2.patch | 8.76 KB | Vidushi Mehta |
Convert array into short array.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | basic.png | 161.26 KB | akash.addweb |
| #2 | 2965857-2.patch | 8.76 KB | Vidushi Mehta |
Comments
Comment #2
Vidushi Mehta commentedComment #3
akash.addweb commented@Vidushi Mehta, Your patch is working fine, I checked it with Pareview standards errors & attached the screenshot for the same.
Comment #4
joelpittetThese patches can be disruptive to other patches in the queue because they touch a lot of code. Typically they will force other bug fixes to get rerolled and if they get in first will cause this one to be rerolled. So this should only be committed right before a release.
Comment #5
leahtard commentedI tested the patch and all applied correctly. After applying the patch, I confirmed that I could still run `drush basic-install` successfully.
@joelpittet, the patch only makes changes to the drush install script. Is this still considered disruptive? I just finalized a new release today which didn't include any updates to this file.
Cheers, Leah
Comment #6
joelpittetIt's great to commit with a new release (right before or just after) to be the least disruptive to patches in the queue (there will likely be some that need to be rerolled regardlress of when this is applied).
Although if there are other parts of the code that need to be converted I'd do that here first.
Comment #7
leahtard commentedThanks @joelpittet! Did a search through the code base and we don't have any other arrays in place. I'll get this one committed and a new release out later this week.
Cheers, Leah
Comment #8
joelpittetWhoops didn't mean to change it without asking. Are you using patch to be ported for another purpose?
Comment #9
Vidushi Mehta commentedOh Great guys! I also go through the code and only found the arrays in drush file. Its good if it's get committed with new release.
Thanks.
Comment #11
leahtard commentedOops, I didn't mean to set it as to be ported. Thanks for fixing @joelpittet.
This patch has now been committed to the dev branch. I will release soon.
Cheers, Leah