The word "Checked" is used in several places, and has two meanings:

1) The enabled state of a check box or radio button (boolean)
2) Something has been examined and verified, as what's the case for the label on the Status report page.

I propose that we add context to the 2nd usage, since using the same translation for both cases is really off in many languages.

CommentFileSizeAuthor
#3 drupal-translation-of-checked-needs-context-2965786-3.patch1.9 KBsvenryen
#2 drupal-translation-of-checked-needs-context-2965786-2.patch1.88 KBsvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
StatusFileSize
new drupal-translation-of-checked-needs-context-2965786-2.patch1.88 KB

Here's the patch.

svenryen’s picture

svenryen commented
StatusFileSize
new drupal-translation-of-checked-needs-context-2965786-3.patch1.9 KB

I missed the args parameter from t() docblock. Here's a patch that works :)

svenryen’s picture

svenryen commented
Status: Active » Needs review
efpapado’s picture

efpapado commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: drupal-translation-of-checked-needs-context-2965786-3.patch, failed testing. View results

svenryen’s picture

svenryen commented
Status: Needs work » Reviewed & tested by the community

I don't know why the comment says the patch failed testing. All tests are green on the "View results" page and there are no Failing classes.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: drupal-translation-of-checked-needs-context-2965786-3.patch, failed testing. View results

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

laravz’s picture

laravz commented
Status: Needs work » Needs review

I've rerun the tests, and they all passed, so I'm resetting the status to Needs review (I've not seen any review remarks).

efpapado’s picture

efpapado commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

One thing that is interesting about this patch is that it adds this context to every translation of the string Checked in core so there is no usage of it being used in the first sense in the issue summary. So we have to ask the question if it is worth breaking people's translations to add this context? There is no fallback to a no context version looking at \Drupal\locale\StringDatabaseStorage::findTranslation() for example.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

I think its worth it in case people mistranslated it it would be a good chance to fix it now. It is such a minimal change that it would be miniscule among all the other string changes / additions in minor release. It should not be backported to 8.6.

  • catch committed aa39748 on 8.7.x 
    Issue #2965786 by svenryen, Gábor Hojtsy: Translation of "Checked" as...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Makes sense to me as well, there's also the possibility of contrib modules using the same one word in a different context.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.