There are some minor dependency injection issues in FieldBlockConfigForm.Patch incoming.

CommentFileSizeAuthor
#5 fieldbloc_di_form_2965649_5.patch2.84 KBsutharsan
#5 interdiff-2965649-4-5.txt2.78 KBsutharsan
#4 fieldbloc_di_form_2965649_4.patch2.63 KBsutharsan
#2 fieldbloc_di_form_2965649_2.patch3.04 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new fieldbloc_di_form_2965649_2.patch3.04 KB
sutharsan’s picture

sutharsan commented
Status: Needs review » Needs work

Patch no longer applies.
Please provide parameter description, according to coding standards.

sutharsan’s picture

sutharsan commented
StatusFileSize
new fieldbloc_di_form_2965649_4.patch2.63 KB

RErolled

sutharsan’s picture

sutharsan commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2965649-4-5.txt2.78 KB
new fieldbloc_di_form_2965649_5.patch2.84 KB

Fixed an error introduced during reroll.
Added some documentation
Changed type hint to interface where possible

sutharsan’s picture

sutharsan commented
Status: Needs review » Fixed

  • Sutharsan committed 1b60e4a on 8.x-2.x 
    Issue #2965649 by Sutharsan, nkoporec: Dependency injection in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.