We need to cleanup codebase because there are still some d7 code and files that should be replaced to follow drupal 8 standards.Also we should use dependency injection.

CommentFileSizeAuthor
#2 fpm_code_cleanup_2.patch36.54 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new fpm_code_cleanup_2.patch36.54 KB

Created a patch which fixes the major part of issues, removed form_alter.inc and moved the code to .module(also deleted some functions that aren't used).Left filetags and .info file since there are already some patches for it.

maaty388’s picture

maaty388 commented
Status: Needs review » Reviewed & tested by the community

Patch applied nicely, marking RTBC

azovsky’s picture

azovsky commented
Status: Reviewed & tested by the community » Fixed

It's released in 3.0.0.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.