Closed (won't fix)
Project:
Allowed Languages
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2018 at 09:41 UTC
Updated:
6 Dec 2023 at 02:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
weseze commentedAttached is POC patch.
Is this the correct way forward for this? Would this be considered for inclusion?
Comment #3
weseze commentedComment #4
heddnInstead of extending NodeRevisionAccessCheck, I think it would be cleaner to extend this module's base class and injecting the
access_check.node.revisionservice and calling it'scheckAccessmethod.Comment #5
heddnComment #6
nterbogt commentedI'm not sure we want to be able to restrict permissions based on languages. The revisions list allows you to see the revisions that have past, view the content in them, and possibly revert.
The problem is, a revision is generally created per language change so that the history looks like:
* en
* en
* fr
* en
* fr
Now if you were to allow a user to revert to the first french revision, you'd find that two en changes that follow it would be reverted. There's no easy way around this so I believe that the module shouldn't actually change permissions for revisions. There is already a 'view revisions' permission and it should be deemed a language unsafe action, and only given to higher level users.
Happy for feedback, or if my understanding is incorrect, but would like to look at it further before catering for language based permissions on revisions.
Comment #7
heddn#6 seems fair to me. Closed, won't fix?
Comment #8
nterbogt commentedHappy to look at it again if additional information comes to light.
Comment #9
bingol@ciandt.com commentedComment #10
bingol@ciandt.com commentedThis patch solves another problem
https://www.drupal.org/project/allowed_languages/issues/3403918
Comment #11
bingol@ciandt.com commentedComment #12
bingol@ciandt.com commented