Closed (fixed)
Project:
Drupal core
Version:
8.6.x-dev
Component:
phpunit
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Apr 2018 at 21:17 UTC
Updated:
23 May 2018 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottComment #4
alexpottWhoops.
Comment #5
borisson_The patch no longer applies, but it looks solid.
Comment #6
idebr commentedReroll against 8.6.x
Comment #7
borisson_The only remaining instances are in
SearchPageCacheTagsTest, or in the legacy tests. I'm not sure if we should postpone this on that conversion, but since @alexpott didn't mention that in the original issue this looks good to go.Comment #8
catchSince the patch does this, it ensures that future conversions won't use the deprecated method, so I think it's fine to get in as is.
Committed 323c56c and pushed to 8.6.x. Thanks!