Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
\Drupal\FunctionalTests\AssertLegacyTrait::assertNoCacheTag
is deprecated but we still use it in core. Let's not.
Proposed resolution
Use $this->assertSession()->responseHeaderNotContains()
instead
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#6 | 2963521-6.patch | 10.53 KB | idebr |
Comments
Comment #2
alexpottComment #4
alexpottWhoops.
Comment #5
borisson_The patch no longer applies, but it looks solid.
Comment #6
idebr CreditAttribution: idebr at ezCompany commentedReroll against 8.6.x
Comment #7
borisson_The only remaining instances are in
SearchPageCacheTagsTest
, or in the legacy tests. I'm not sure if we should postpone this on that conversion, but since @alexpott didn't mention that in the original issue this looks good to go.Comment #8
catchSince the patch does this, it ensures that future conversions won't use the deprecated method, so I think it's fine to get in as is.
Committed 323c56c and pushed to 8.6.x. Thanks!