Spelling mistake in the file "ClientFactory.php". I have uploaded the patch for the same. Kindly review.

CommentFileSizeAuthor
#6 Typo_fixed_in_redis.png4.33 KBzalak.addweb
#4 correct-3.jpg7.94 KBshobhit_juyal
#4 correct-2.jpg9.91 KBshobhit_juyal
#4 correct-1.jpg16.52 KBshobhit_juyal
#4 spell_mistake-2962281-4.patch1.02 KBshobhit_juyal
#3 Redis_Before_1.png2.01 KBzalak.addweb
#3 Redis_before2.png1.82 KBzalak.addweb
#3 Redis_After_1.png5.38 KBzalak.addweb
#3 Redis_After_2.png2.13 KBzalak.addweb
#3 Redis_typo_remain.png7.28 KBzalak.addweb
#2 spell_mistake-2962281-2.patch670 bytesshobhit_juyal
spell_mistake-1.patch669 bytesshobhit_juyal

Comments

shobhit_juyal created an issue. See original summary.

shobhit_juyal’s picture

shobhit_juyal commented
StatusFileSize
new spell_mistake-2962281-2.patch670 bytes
zalak.addweb’s picture

zalak.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Redis_typo_remain.png7.28 KB
new Redis_After_2.png2.13 KB
new Redis_After_1.png5.38 KB
new Redis_before2.png1.82 KB
new Redis_Before_1.png2.01 KB

@shobhit_juyal, Thank you for the patch, it works well as requirements but you missed one spell in the same file. PFA for the same.

shobhit_juyal’s picture

shobhit_juyal commented
StatusFileSize
new spell_mistake-2962281-4.patch1.02 KB
new correct-1.jpg16.52 KB
new correct-2.jpg9.91 KB
new correct-3.jpg7.94 KB

Thanks, @Disha.addweb,

Here is the updated one. please review

shobhit_juyal’s picture

shobhit_juyal commented
Status: Needs work » Needs review
zalak.addweb’s picture

zalak.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Typo_fixed_in_redis.png4.33 KB

@shobhit_juyal, Thanks for the quick response, it works well and updates the change. PFA for the same.

Thank you, again !

  • Berdir committed bb25573 on 8.x-1.x authored by shobhit_juyal 
    Issue #2962281 by shobhit_juyal, Pranjal.addweb: Spell mistake in...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.