Problem/Motivation

pathauto.schema.yml has a duplicate key for "ignore_words" in pathauto.settings. This will trigger the following error message when running a PHPUnit test:

Duplicate key "ignore_words" detected whilst parsing YAML. Silent handling of duplicate mapping keys in YAML is deprecated since Symfony 3.2 and will throw \Symfony\Component\Yaml\Exception\ParseException in 4.0 on line 30.

Proposed resolution

Remove the duplicate key for "ignore_words" in pathauto.settings.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#8 pathauto-duplicate_ignore_words_config_schema-2961850-8.patch764 bytesidebr
#8 interdiff-6-8.txt365 bytesidebr
#6 interdiff.txt670 bytesVidushi Mehta
#6 2961850-6.patch445 bytesVidushi Mehta
duplicate-key-ignore_words.patch499 byteskdebisschop

Comments

kdebisschop created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 8.x-1.0 » 8.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)

This might already be fixed in the latest release.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

The patch didn't apply, so pretty sure about that, feel free to re-open if you can confirm otherwise.

decafdennis’s picture

decafdennis commented
Status: Closed (duplicate) » Needs work

This is still an issue, and is causing a slew of deprecation warnings in our PHPUnit tests.

You can manually verify there are duplicate ignore_words keys here: http://cgit.drupalcode.org/pathauto/tree/config/schema/pathauto.schema.yml

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I see, what was fixed was a duplicate key in the actual configuration, not the schema.

Still needs a patch that actually applies though.

Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Needs work » Needs review
StatusFileSize
new 2961850-6.patch445 bytes
new interdiff.txt670 bytes

Added a patch for the same with the interdiff.

Status: Needs review » Needs work

The last submitted patch, 6: 2961850-6.patch, failed testing. View results

idebr’s picture

idebr commented
Title: Duplicate key "ignore_words" detected whilst parsing YAML » pathauto.schema.yml has a duplicate key for "ignore_words" in pathauto.settings
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new interdiff-6-8.txt365 bytes
new pathauto-duplicate_ignore_words_config_schema-2961850-8.patch764 bytes
  1. Updated the issue title and description to more accurately reflect the problem
  2. Retained one of the duplicate key for "ignore_words" in pathauto.settings

  • Berdir committed 09d3c85 on 8.x-1.x authored by idebr 
    Issue #2961850 by Vidushi Mehta, idebr, kdebisschop: pathauto.schema.yml...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.