Missing hook_help text in youtubechannel.module file

CommentFileSizeAuthor
#5 2961376-1.patch1.21 KBlomasr
#4 Before_patch_youtube.png6.39 KBzalak.addweb
#4 After_youtube1.png29.06 KBzalak.addweb
#4 After_youtube2.png23.45 KBzalak.addweb
#2 2961376.patch1.05 KBlomasr

Comments

lomasr created an issue. See original summary.

lomasr’s picture

lomasr commented
StatusFileSize
new 2961376.patch1.05 KB

Adding a patch

lomasr’s picture

lomasr commented
Status: Active » Needs review
zalak.addweb’s picture

zalak.addweb commented
Status: Needs review » Needs work
StatusFileSize
new After_youtube2.png23.45 KB
new After_youtube1.png29.06 KB
new Before_patch_youtube.png6.39 KB

@lomasr, Thanks for the patch, but need for the standard corrections that are mentioned in https://www.drupal.org/docs/develop/documenting-your-project/help-text-s.... It creates the help page as shown in below image, but have an issue as I described.

lomasr’s picture

lomasr commented
StatusFileSize
new 2961376-1.patch1.21 KB

Patch added

lomasr’s picture

lomasr commented
Status: Needs work » Needs review
keshavv’s picture

keshavv commented

@lomasr
I have tested yor #5 patch , working fine .

lomasr’s picture

lomasr commented
Status: Needs review » Reviewed & tested by the community
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Reviewed & tested by the community » Fixed

Already fixed in 8.x-2.x-dev branch.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Fixed » Needs work

The Drupal coding standards issue is not fixed on 8.x-2.x-dev branch. Set it to "Needs work".
Sorry for my previous mistake.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs work » Reviewed & tested by the community

#5 works perfectly! Back to "Reviewed & tested by the community".

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Version: 8.x-2.x-dev » 8.x-3.x-dev

  • i-trokhanenko committed 4cb9210 on 8.x-3.x authored by lomasr 
    Issue #2961376 by lomasr, Pranjal.addweb: Missing hook_help text in...
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.