Hello! Submitting my new module, Simple Integrations, for review. It can be found here: https://www.drupal.org/project/simple_integrations

Synopsis

This is a Drupal 8 module.

This module wraps around Drupal's core httpClient class and automatically configures a connection based on config variables.

When used correctly, the module will save developers from having to add connection details in code, or from creating custom forms to configure the details, as it's all provided for them. It reduces the amount of hardcoding required and allows config integrations to be stored as exportable config.

There is an admin interface which allows administrators to view and edit (but not add) integrations.

It's used for REST connections but there is the potential to expand to SOAP callbacks as well, using an external library, which is recommended in the module's readme.

Project URL

https://www.drupal.org/project/simple_integrations
https://git.drupal.org/project/simple_integrations.git

Comments

Sophie.SK created an issue. See original summary.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
Issue summary: View changes
teemuaro’s picture

teemuaro commented
Status: Needs review » Reviewed & tested by the community

I was able to install and use the module without problems in a test environment. Here's my review.

Automated Review

Pareview.sh shows no problems: https://pareview.sh/pareview/https-git.drupal.org-project-simple_integra...

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Maybe you could consider adding an example installation file to your Readme/module. Creating the integration entity was super-easy in the end, but it took a couple of Google searches to do, having never done that before. This is of course not a release blocker in any way, since the Readme is otherwise really good but something to consider.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
Code seems to follow Drupal style guides and is clean and easy to read.

I'm not sure if one review is enough for RTBC but everything looks good to me. I'll mark this as RTBC, feel free to move it back to Needs Review if more reviews are needed.

This review uses the Project Application Review Template.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented

Hi @teemuaro

Thanks for the review! I like the suggestion about adding an example install file to the module. Do you think you could raise an issue in the project and I can add it/credit you?

I don't know how many people need to review this. Seems like I'll need a role to add coverage. I'm not totally sure of the process here, so I'll leave it as RTBC for a bit. Thanks again!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented

Thanks, @kiamlaluno! Much appreciated - opting in now! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.