Module works great unless there is no end date with the module optional_end_date. This will also be the behavior for 8.6 per https://www.drupal.org/project/drupal/issues/2794481.

CommentFileSizeAuthor
#17 date_range_formatter-optional_end_date-2961280.patch3.84 KBjaime@gingerrobot.com
#16 date_range_formatter-optional_end_date.patch3.82 KBjaime@gingerrobot.com
#15 date_range_formatter-optional_end_date.patch4 KBjaime@gingerrobot.com
#14 date_range_formatter-compatibility-with-optional_end_date-and-date_all_day-2961280-14.patch8.75 KBpaul_serval
#13 date_range_formatter-compatibility-with-optional_end_date-and-date_all_day-2961280-13.patch8.27 KBnetsliver
#12 date_range_formatter-compatibility-with-optional_end_date-and-date_all_day-2961280-12.patch4.07 KBnetsliver
#11 date_range_formatter-compatibility-with-optional_end_date-9.0.x-2961280-11.patch3.39 KBquentin massez
#10 date_range_formatter-optional_end_date-2961280-10.patch3.64 KBpameeela
#9 Screen Shot 2020-12-09 at 5.21.07 pm.png6.12 KBpameeela
#8 date_range_formatter-compatibility-with-optional_end_date-9.0.x-2961280-8.patch3.68 KBpeterhebert
#3 2961280-date_range_formatter-optional_end_date.patch3.47 KBjohn.money

Comments

john.money created an issue. See original summary.

john.money’s picture

john.money commented
Issue summary: View changes
john.money’s picture

john.money commented
StatusFileSize
new 2961280-date_range_formatter-optional_end_date.patch3.47 KB

Added patch.

dan_metille’s picture

dan_metille commented
Version: 8.x-3.1 » 8.x-3.x-dev

The patch fails on version 3.1 but applied ok on the dev version.

lias’s picture

lias commented

Patch worked against 3x dev version for me as well.

brianfisher’s picture

brianfisher commented
Status: Active » Needs review

works for me too

maryluellyn’s picture

maryluellyn commented

Patch works for my site on 3.x-dev
Thank you!

peterhebert’s picture

peterhebert commented
StatusFileSize
new date_range_formatter-compatibility-with-optional_end_date-9.0.x-2961280-8.patch3.68 KB

Uploading similar patch to #3, but for for 9.0.x branch for Drupal 9.

pameeela’s picture

pameeela commented
StatusFileSize
new Screen Shot 2020-12-09 at 5.21.07 pm.png6.12 KB

Without the patch, the date does not display at all. Using the patch in #3, I am getting this when there is no end date:

pameeela’s picture

pameeela commented
StatusFileSize
new date_range_formatter-optional_end_date-2961280-10.patch3.64 KB

Attached patch works for optional end dates that include a time.

quentin massez’s picture

quentin massez commented
StatusFileSize
new date_range_formatter-compatibility-with-optional_end_date-9.0.x-2961280-11.patch3.39 KB

Hi everyone and thank for the patch !

The patch for 9.0.x in #8 didn't work for me.
Here's the patch I used that solved this issue.

netsliver’s picture

netsliver
Primary language French
Location Chelles
commented
StatusFileSize
new date_range_formatter-compatibility-with-optional_end_date-and-date_all_day-2961280-12.patch4.07 KB

Add compatibility with date_all_day

netsliver’s picture

netsliver
Primary language French
Location Chelles
commented
StatusFileSize
new date_range_formatter-compatibility-with-optional_end_date-and-date_all_day-2961280-13.patch8.27 KB

Add compatibility with date_all_day and all day on all format

paul_serval’s picture

paul_serval commented
StatusFileSize
new date_range_formatter-compatibility-with-optional_end_date-and-date_all_day-2961280-14.patch8.75 KB

Patch #13 + D9 compatibility

jaime@gingerrobot.com’s picture

jaime@gingerrobot.com commented
StatusFileSize
new date_range_formatter-optional_end_date.patch4 KB

I've noticed we need some documentation for this module too. The default settings in the module are ignored as even if getSetting does merge with default it will only add new keys to the array. Anything that already exists preferences the settings we already have.

The documentation should include something about going into the display field settings and setting up the date formats so they are primary ones it uses.

Anyway here's an update to patch from #10 to use Drupal 9 functions and the D9 branch.

jaime@gingerrobot.com’s picture

jaime@gingerrobot.com commented
StatusFileSize
new date_range_formatter-optional_end_date.patch3.82 KB

Updated to make sure if there is no date or if end date equals start date then use single format.

jaime@gingerrobot.com’s picture

jaime@gingerrobot.com commented
StatusFileSize
new date_range_formatter-optional_end_date-2961280.patch3.84 KB

There was an error with my last patch where it didn't check if the delta key existed before operating on the array. Fixed that.

villette’s picture

villette commented
Status: Needs review » Reviewed & tested by the community

Path in #17 works great with latest version, I'm moving this to RTBC

sudishth’s picture

sudishth commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.