Closed (fixed)
Project:
Link
Version:
7.x-1.5-beta3
Component:
Code
Priority:
Critical
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
15 Apr 2018 at 16:31 UTC
Updated:
5 Jun 2018 at 04:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pifagor commentedComment #3
billywardrop commentedThats great news! I will test it on our distribution in the next few days.
Comment #4
billywardrop commentedI have tested release 7.x-1.5-beta3 and I there were no issues in my installation. I can add any domain name extension and I experienced no errors.
Comment #5
billywardrop commentedHere are screenshots from before and after the module upgrade
Comment #6
billywardrop commentedComment #7
pifagor commentedComment #8
vinmassaro commentedIt looks like a regression was introduced by this issue #2553705: Static Title does not show up when using 'Optional URL' + 'Static Title' with an empty URL
If you create a link field with a static title, and set the label to hidden in the display settings, the title still displays if you create a node and leave the link field empty. There is also a note about that in this post. Thanks!
Comment #9
vinmassaro commentedComment #10
alex_optim+1
Comment #11
pifagor commentedHello @vinmassaro
I wrote the answer here - https://www.drupal.org/project/link/issues/2553705#comment-12593260
Comment #12
billywardrop commentedDo you want this retested, including the new patch? Would I test 7.x-1.x-dev?
Comment #13
pifagor commentedHello @billywardrop. We have to test only version 7.x-1.5-beta3 and the compatibility of versions 7.x-1.5-beta3 and 7.x-1.4
I need a confirmation from @vinmassaro that I responded to his remarks.
Comment #14
billywardrop commentedThanks @pifagor, let me know when you get confirmation and I will test again
Comment #15
pifagor commentedI will post the release date on May 14th. Because you need to more perfectly test the issue https://www.drupal.org/project/link/issues/2553705.
Comment #16
pifagor commentedComment #17
alex.mazaltov+1 review.
I have reviewed latest changes for this module and i think that we are ready to release alpha version.
AM
Comment #18
pifagor commentedDone - https://www.drupal.org/project/link/releases/7.x-1.5
Comment #19
pifagor commentedComment #20
Chris CharltonFWIW, seeing the release tagged on a (new) '7.x-1.x-test' branch was a bit confusing.
Comment #21
pifagor commenteda (new) '7.x-1.x-test'
Delete, thanks