A best practices check on the module suggests using dependency injection instead of global getters within the Authmap service and the redirect controller:
FILE: openid_connect/src/Authmap.php
--------------------------------------------------------------------------
88 | WARNING | User::load calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------
FILE: openid_connect/src/Controller/RedirectController.php
--------------------------------------------------------------------------
172 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | openid_connect-2960884.patch | 3.35 KB | mario steinitz |
Comments
Comment #2
mario steinitzThis patch fixes the suggested use of dependency injection.
Comment #4
mario steinitzComment #5
sunThis commit broke authorize() as you forgot to inject a config service into the redirect controller.
Comment #6
sunComment #7
hirvinen commentedOpenIDRedirectController inherits Drupal\Core\Controller\ControllerBase::config so there is no need to inject another config factory.
Comment #9
jcnventuraJust setting back the title to reflect the real status.