Problem/Motivation

In the footer, the link "Find out more" covers the area of the parent div, this means any hover over the parent div activates the underline of the link. See included screenshot.

Proposed resolution

Modification to the css, current CSS is as follows:

.block-type-footer-promo-block .footer-promo-content a {
background-color: inherit;
display: block;
color: #fff;
font-weight: bold;
text-decoration: none;
}

Suggest removing "display:block".

Remaining tasks

Modify the CSS.

User interface changes

Modify the link to the target is only the text.

Original report by TaoStyle

CommentFileSizeAuthor
#7 Screenshot from 2018-04-27 16-15-13.png28.38 KBMukeysh
#5 Screen Shot 2018-04-13 at 13.56.04.png434.76 KBsusannecoates
#5 Screen Shot 2018-04-13 at 14.02.18.png469.11 KBsusannecoates
#4 core-umami-footer-link-2960797-3-8.6.x.patch614 bytesseeallie
Screen Shot 2018-04-13 at 12.53.43.png861.38 KBTaoStyle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TaoStyle created an issue. See original summary.

TaoStyle’s picture

TaoStyle CreditAttribution: TaoStyle as a volunteer commented

Working on this for Nashville 2018.

matias’s picture

matias CreditAttribution: matias as a volunteer commented

Working on this as part of the sprint on DrupalCon Nashville 2018.

seeallie’s picture

seeallie CreditAttribution: seeallie as a volunteer commented
FileSize
core-umami-footer-link-2960797-3-8.6.x.patch614 bytes

Adding a patch for this, along with @matias, @TaoStyle, and @susannecoates. Especial thanks to @chrisdarke, at DrupalCon Nashville2018

susannecoates’s picture

susannecoates CreditAttribution: susannecoates as a volunteer commented
FileSize
Screen Shot 2018-04-13 at 14.02.18.png469.11 KB
Screen Shot 2018-04-13 at 13.56.04.png434.76 KB

Tested, working in Drupal 8.6.1-dev. Before and after screenshots attached:
before
After

seeallie’s picture

seeallie CreditAttribution: seeallie as a volunteer commented
Status: Active » Needs review
Mukeysh’s picture

Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
Screenshot from 2018-04-27 16-15-13.png28.38 KB

Patch applied successfully and this is working as mentioned above. Attaching screenshot for ref.
footer-link

Mukeysh’s picture

Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community

  • lauriii committed 6620967 on 8.6.x 
    Issue #2960797 by seeallie, susannecoates, TaoStyle, matias, ChrisDarke...

  • lauriii committed 6db0869 on 8.5.x 
    Issue #2960797 by seeallie, susannecoates, TaoStyle, matias, ChrisDarke...

lauriii credited ChrisDarke.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed 6620967 and pushed to 8.6.x. Also cherry picked 6db0869 and pushed to 8.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.