CommentFileSizeAuthor
#8 interdiff_4_6.txt124 byteskrismaye
#8 gender-create-info-file-2960756-6-8.patch558 byteskrismaye
#4 gender-create-info-file-2960756-4-8.patch560 byteskrismaye

Comments

ksartain created an issue. See original summary.

krismaye’s picture

krismaye commented

Working on this at DrupalCon Nashville 2018

krismaye’s picture

krismaye commented
Assigned: Unassigned » krismaye
krismaye’s picture

krismaye commented
StatusFileSize
new gender-create-info-file-2960756-4-8.patch560 bytes
krismaye’s picture

krismaye commented
Status: Active » Needs review
bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs review » Needs work

I think the '#' before the core is not required as per the Drupal documentation(https://www.drupal.org/docs/8/converting-drupal-7-modules-to-drupal-8/st...). Please remove the '#' in front of the core. Everything else is fine I guess.

krismaye’s picture

krismaye commented
Status: Needs work » Needs review
krismaye’s picture

krismaye commented
StatusFileSize
new gender-create-info-file-2960756-6-8.patch558 bytes
new interdiff_4_6.txt124 bytes

Updating core line

  • alexdmccabe committed 103ac3b on 8.x-1.x authored by krismaye 
    Issue #2960756 by krismaye, ksartain, bhanuprakashnani: Convert .info to...
alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
Status: Needs review » Fixed

Marking this as fixed. Thanks!

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented

Updating to hopefully add credit to DD&I.

alexdmccabe’s picture

alexdmccabe
he/him
Primary language English
Location Orlando, FL, US / Seminole lands
commented
Version: » 8.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.