Custom caption based on a views field

Did you find a solution in the meantime? We are looking for a similar thing, but mainly for a way to display captions next to the thumbnails (maybe we disabled something by accident?). Thanks, Frank

see also my request: https://www.drupal.org/project/photoswipe/issues/2984783

I think paid development might be an option here, if you can't develop a patch inhouse. Perhaps someone is interested?

I added an option of a custom caption with tokens, just like in the Colorbox module. It's actually more flexible than using one views field as you can combine more than one field and add your own markup if needed. If you only want one field, just use one token, like [node:body].
There seems to be some work in progress in 8.x-2.x-dev that kind of breaks some of functionality working in the 8.x-2.2 release. So I am going to post two patches: one will apply to 8.x-2.x-dev (to be hopefully committed one day) and the other will apply to 8.x-2.2 - for those who run the release version and need this right now. Please review and test.

Re-posting the same patches to be tested against correct version (and not tested at all in case of the 8.x-2.2 patch). Could not figure out how to change that without re-posting.

Added a couple of enhancements:
- a text field is way too small for a good fat caption using lots of tokens; changed to textarea
- made sure the token replacer respects the current page language

Thank you very much, should a token browser link (AJAX) be added perhaps? Eventually in the field description?

Two more questions:

1. Where does the output filtering and token replacement happen? I couldn't find that in the patch. It's also important for security reasons.

2. Can you please explain this change? Isn't that supposed to break other things?

-  $entity = $item->getParent()->getValue();
+  $entity = $item->getParent()->getParent()->getValue();

@Anybody:

should a token browser link (AJAX) be added perhaps? Eventually in the field description?

I'm not sure I understand the question - do you mean the list of available tokens? It's right there, under the Custom caption field.

Where does the output filtering and token replacement happen?

In photoswipe.theme.inc:

+      case 'custom':
+        $entity_type = $entity->getEntityTypeId();
+        $caption = \Drupal::token()->replace($settings['photoswipe_caption_custom'],
+          [$entity_type => $entity, 'file' => $item],
+          ['clear' => TRUE, 'langcode' => \Drupal::languageManager()->getCurrentLanguage()->getId()]);
+        break;
+
       default:
         // Assume the user wants to use another node field as the caption.

Can you please explain this change?

Sure: I initially based my code on 8.x-2.2 where the entity is obtained by the double getParent() call. It works for me (and apparently for the other 1207 people who use the module with Drupal 8). When I tried to create a "proper" patch against dev, I noticed that the double getParent() call has been replaced by a single getParent() there which is probably very good for the Media use case but totally breaks everything when you work with simple image fields in simple nodes.
The change in dev was introduced by https://www.drupal.org/project/photoswipe/issues/2977943 - I linked it to this issue and made a few comments in that issue, including a proposed patch that does away with all this getParent() monkey business. My patch and whatever is done under that issue should be somehow merged together so that the module works with both Media fields and simple image fields.

Thank you very very much for your clarification, @ndlarge!
1) Sorry then it's my mistake, I couldn't find that piece in the code.

2) Ok... yes I'm also quite unhappy with the current state... would you like to help me clean up and become co-maintainer of this module? I was also only a "helper" in fixing several problems. That would be great!
Of course we should ensure everything works as expected in all cases... What about writing tests in the next step? Meta-issue? Would you be interested?

@Anybody:
I am flattered by your co-maintainer proposal but I'm afraid I'm not qualified/experienced enough to maintain a popular module like this (for example I have no idea how to write tests, I am not too fluent in git etc etc etc) and last but not least I don't have the time it would take. I simply wanted Photoswipe for the only site I am developing for myself, found a few shortcomings, did some copying and pasting, was satisfied with the result and decided to share it with the community. I am more than happy to share what I developed and what works for me but I am hardly able to clean up other people's code dealing with stuff (like Media) I have no clue about.
Maybe @Niklan would be interested in reconciling media and non-media use cases? He is much more experienced than me.

Thank you ndlarge for your honesty, we'd really appreciate some more help. Then back to topic!

Retest against latest dev after #2977943: Support Media and Entity References was committed to dev.

The patch needs a reroll against the latest dev now. Thanks!

Patch rerolled against the latest dev. Works for me with image fields in entity display and views contexts, didn't test with Media!

Thank you all. This is now in the latest 8.x-2.x dev release. Please test!