The entity_print_views module throws a warning when the entity_print key is not defined in the theme.info file

Notice: Undefined index: entity_print in _entity_print_views_get_css() (line 42 of sites/all/modules/contrib/entity_print/modules/entity_print_views/entity_print_views.module).

Warning: Invalid argument supplied for foreach() in _entity_print_views_get_css() (line 42 of sites/all/modules/contrib/entity_print/modules/entity_print_views/entity_print_views.module).

For reproducing this bug you just need to create a PDF display on a view and browse this view with a vanilla bartik (or any other) theme.

CommentFileSizeAuthor
#2 entity_print-undefined_index_in_views-2959421-2.patch1.42 KBtucho

Comments

tucho created an issue. See original summary.

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
commented
Status: Active » Needs review
StatusFileSize
new entity_print-undefined_index_in_views-2959421-2.patch1.42 KB

I have uploaded a patch that solves this issue.

It just adds an IF before using the entity_print key.

benjy’s picture

benjy commented 
  1. +++ b/modules/entity_print_views/entity_print_views.module
@@ -32,16 +32,18 @@ function _entity_print_views_get_css($view) {
-  if (isset($theme_info['entity_print']['views']['all'])) {
...
+  if (isset($theme_info['entity_print']['views'])) {
...
+    if (isset($theme_info['entity_print']['views']['all'])) {

    Why is this part required? The one isset() on the deepest key should be sufficient? 

  2. +++ b/modules/entity_print_views/entity_print_views.module
@@ -32,16 +32,18 @@ function _entity_print_views_get_css($view) {
-  foreach ($theme_info['entity_print']['views'] as $view_name => $css) {

    Does the loop simply need to be inside the isset() call?

It would be great if we could add an additional test for this?

jannakha’s picture

jannakha commented
Status: Needs review » Closed (outdated)