Problem/Motivation

I was doing the individual follow up from https://www.drupal.org/project/drupal/issues/2951715#comment-12559059 then find out that we cannot add or log the message on MigrateSkipProcessException

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-2959087-3-6.txt2.58 KBrakesh.gectcr
#5 2959087-6.patch1.3 KBrakesh.gectcr
#3 2959125-1.patch1.97 KBrakesh.gectcr

Comments

rakesh.gectcr created an issue. See original summary.

jofitz’s picture

jofitz
he/him
commented
Assigned: Unassigned » jofitz

Aha, I think I see what's going on here, patch coming...

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
StatusFileSize
new 2959125-1.patch1.97 KB
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

Sorry Jo, Didn't refreshed the page...

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
StatusFileSize
new 2959087-6.patch1.3 KB
new interdiff-2959087-3-6.txt2.58 KB
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
jofitz’s picture

jofitz
he/him
commented
Assigned: jofitz » Unassigned

The last submitted patch, 3: 2959125-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Can we add a test to see what is going on here? Also some nits.

+++ b/core/modules/migrate/src/MigrateSkipProcessException.php
@@ -6,5 +6,36 @@
+  ¶
...
+  ¶
...
+  ¶

Whitespace.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

Its my bad, Some reasom My php Storm done this to me very regulardly.... :(

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Issue tags: +Nwdug_may18
jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Closed (cannot reproduce)

I cannot see the problem here (despite my comment in #2!)

I have been able to add MigrateSkipProcessException messages in both of the child tickets that this is apparently blocking.

Setting to Closed, but happy to look again if someone can provide me with more details of the problem.