Closed (fixed)
Project:
Commerce Razorpay Payment Integration
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Apr 2018 at 06:34 UTC
Updated:
30 Sep 2022 at 11:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
arunkumarkCreated the patch to resolve the coding standard issue.
Comment #3
krina.addweb commented@arunkumark, it would be good if you solve all the errors shown in Preview report. I attached the screenshot for the same.
Comment #4
Deepthi kumari commentedFixed the coding standard errors. Applied the patch, needs review.
Comment #5
ankitjain28may commentedPatch #4 is applied successfully and fixing all the errors, attached images before and after the patch. Thanks, Marking it RTBC.
Comment #6
i-trokhanenkoComment #7
i-trokhanenkoI can't apply patch #4 to the current module version, please update. Thanks!
Comment #8
i-trokhanenkoComment #9
saphemmy commentedComment #10
libbna commented@saphemmy are you still working on this issue?
Comment #11
chakkche commented@saphemmy are you still working on this issue?
Comment #12
saphemmy commentedComment #13
chakkche commentedI will work on this.
Comment #14
chakkche commentedBelow patch fixes the coding standard issues.
Comment #15
libbna commentedApplied #14 patch and found these errors.
Comment #16
chakkche commentedComment #17
chakkche commentedComment #18
libbna commentedI have reviewed #14 patch again and this time I found no errors. Last time I must have tested on wrong version.
Added a screenshot and marking it as RTBC.
Comment #19
nehajyoti commented@libnna, check the functionality as well after applying the patch.
Comment #20
i-trokhanenkoComment #21
lucasbaralmPatch failed to apply on 8.x-1.x, moving to Needs Work.
Output:
Comment #22
mrinalini9 commentedRerolled patch #14 for 8.x-1.x, please review it.
Comment #23
lucasbaralmThe patch applied cleanly and resolved the remaining code standard issues, not modifying the module functionality. Running phpcs there was only one warning remaining not relevant. Moving to RTBC.
Comment #24
nehajyoti commentedfrom patch #22.
Please fix the typo on line number 79 of RazorpayForm.php file.
Comment #25
lucasscTypo fixed.
Comment #26
vitorbs commentedI'll review.
Comment #27
vitorbs commentedThe #25 patch fixes the typo from the #22 patch, now the word "redirect" is correct, moving to RTBC.
Comment #28
vitorbs commentedComment #30
nehajyoti commented