When you land on the 'Automatic label' tab on a given entity type, you're immediately presented with a big form. However, none of the settings make sense if the initial set of radios is set to 'Disabled' (which is the default case). To avoid confusion, we should use #states to hide the other settings unless auto_entitylabel is enabled for this entity type.
Before (current behavior)

After
Initial state, AEL is disabled

AEL is enabled
(The same behavior works for all the other radios).

| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2958565-1.hide-settings-if-auto_entitylabel-is-disabled.patch | 3.19 KB | dww |
| #2 | 2958565-1.auto_entitylabel-after-enabled.png | 314.72 KB | dww |
| #2 | 2958565-1.auto_entitylabel-after-disabled.png | 194.3 KB | dww |
| #2 | 2958565-1.auto_entitylabel-before.png | 314.9 KB | dww |
Comments
Comment #2
dwwWorking patch. Added screenshots to the summary.
The only slightly ugly thing is that you can't use #states directly on non-form elements, so I wrapped the 'token_help' part of the render array in a
#type => 'container'. Other than that, the patch probably speaks for itself.Comment #3
renatog commentedI applied the patch #2. It's basic-way and functional. Works good for me.
Comment #5
renatog commentedCommitted to the dev branch. Thanks. Best,