We have to convert the module to short array syntax as per new coding standards.

CommentFileSizeAuthor
#5 short-syntax-array-convert-2958351-8.x-1.x-dev-5.patch31.71 KBoksana-c
#3 after-applying-patch.png87.59 KBharshita29
#2 short-syntax-array-Convert-2958351-8.x-1.x-dev-2.patch31.55 KBprashant.c

Comments

Prashant.c created an issue. See original summary.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Active » Needs review
StatusFileSize
new short-syntax-array-Convert-2958351-8.x-1.x-dev-2.patch31.55 KB

Patch needs to be reviewed.

harshita29’s picture

harshita29 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after-applying-patch.png87.59 KB

Hi @Prashant.c
Your patch applied cleanly and it converted all short array syntax according to the new coding standards.Please refer the attached screenshot.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented

Any updates on this still in RTBC ?

oksana-c’s picture

oksana-c commented
Version: 8.x-1.0 » 8.x-1.x-dev
StatusFileSize
new short-syntax-array-convert-2958351-8.x-1.x-dev-5.patch31.71 KB

rerolled the patch against latest dev version since some hunks have failed to apply

  • oksana-c committed cc5efcb on 8.x-1.x 
    Issue #2958351 by Prashant.c, harshita29, oksana-c: Convert module to...
oksana-c’s picture

oksana-c commented
Status: Reviewed & tested by the community » Fixed
oksana-c’s picture

oksana-c commented
Status: Fixed » Closed (fixed)
chris matthews’s picture

chris matthews commented
Parent issue: » #3081271: Plan for Protected Pages 8.x-1.2 release