Closed (fixed)
Project:
Age Verification
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Apr 2018 at 09:29 UTC
Updated:
4 Apr 2019 at 10:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
_bryanxu commentedThe processInbound is only called once. Should use Event Subscriber instead.
Comment #3
BigEd commentedThanks for the info this might have been a recent change as we were not seeing these issues, I will do some testing on this and update accordingly.
Patches are welcome.
Comment #4
LiquiDetail commentedI would like to help get this up and running but would like some guidance. If someone could point me in the right direction for fixing this module. I am under a timeline and need this pretty quick. Please Advise
Comment #5
BigEd commentedSorry, I was away on holiday when you posted this.
Yes any help is good, but actually, I don't think there is too much to do to get the basic functionality bug free again I will try and take a look through later and make suggestions for where we can make changes and see if can get this running again quickly for you. It was working ok recently but due to the large changes with the way D8 works it just needs to be realigned.
Then we are also talking about extra feature requests, what is it that you need that is not provided already?
Comment #6
BigEd commentedI have had some time to look at this and it looks like a simple fix, I going to make a new patch.
Looks like it just needs a change to the default value before you set admin configuration for the module as you can't access the login form to set the admin configuration settings without it, I guess this must have been a change somewhere along the development of D8 as this module was built in early Alpha.
Comment #7
gavin.hughes commentedSo ya know how it is ya start out to fix a bug and then ya turn around and realize you've completely lost the run of yourself!
I couldn't get this working reliably in the last few versions using drupal core and fresh install. I'm not sure if moving to an event subscriber is the best way to go but it does seem that processInbound is cached or there is issues with using this caching and the redirection to the intended request.
So this patch might serve as the basis if moving to event subscriber.
I made other changes
- used the destination parameter to send the user to their requested url (I don't know if thats the best way to do things)
- the skip paths is done with urls without a / prefix considering that the rest of drupal 8 blocks etc don't do this then I think this should follow the same routine.
Don't shoot me for getting carried away!!
Comment #8
baikho commentedComment #9
BigEd commentedThanks, Gavin, yes I know what you mean once you start making changes in code you just start writing and making changes till late in the night. I was aware the changes in D8 needed to have been kept up with and agree it needs to move across. The issue has been just opening the file up and making the changes seems to be on my forever to do list.
I reckon that there is a use case for this module so I will get this moved across so the module is working well, moving to the event subscriber will solve a few issues with this module.
No i won't shoot you ha, I really appreciate you starting this as it gives me a kick up the bum to work on it. Lets get this reviewed and a new patch as there's a couple of other fixed I need to merge into a new dev release.
Comment #10
BigEd commented@gavin.hughes Picking this up for testing and its not actually not to bad for changes, they make sense.
There are quite a few things that I haven't dealt with yet like ignoring on admin paths I notice you corrected the /admin. I am thinking it would be better to check if the user has roll rather than hardcoded path values.
I will probably roll this and a couple of other things I am thinking of changing into separate issues and move this through.
Comment #11
BigEd commentedFailed
error: patch failed: src/AgePathProcessor.php:1
error: src/AgePathProcessor.php: patch does not apply
Needs to be rerolled against updated version
I can look at this and repatch it.
Comment #12
BigEd commentedMade changes and merged to 8.1-alpha1
Thanks @gavin.hughes
Comment #13
BigEd commented