Hello!

There was already lots of translation-friendly work conducted in the module :) I think one of the last missing pieces is the 'root' token for taxonomy term.

Much like #2772673: Provide tokens for referenced entities in the active language., the problem is as following:

  1. Create a parent term
  2. Create a child term
  3. Translate both. Have both source translation be in English and translation in German.
  4. For German language, request root token of the child term and observe the English parent term name in the output, whereas expected would be its German label.
CommentFileSizeAuthor
#4 rerolled-2957289-4.patch1.13 KBVidushi Mehta
#2 2957289-token-term-root-translation-2.patch1.13 KBbucefal91
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bucefal91 created an issue. See original summary.

bucefal91’s picture

bucefal91 CreditAttribution: bucefal91 at Websolutions Agency commented
Status: Active » Needs review
FileSize
2957289-token-term-root-translation-2.patch1.13 KB

Here's the patch that translates root term before putting its label into the token + a test that pin points the issue.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Looks good but needs a reroll, sorry.

Yay for providing a test, would be even better if you provide a test-only patch (upload that first), that shows that it fails the tests without the fix.

Vidushi Mehta’s picture

Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commented
Status: Needs work » Needs review
FileSize
rerolled-2957289-4.patch1.13 KB

Here's a rerolled patch. Patch doesn't apply on latest version.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.