Services should be implemented using dependency injection.

CommentFileSizeAuthor
#3 interdiff_tagcloud_di_2956677_2_3.txt3.13 KBuseernamee
#3 tagcloud_di_2956677_3.patch11.25 KBuseernamee
#2 tagcloud_di_2956677_2.patch8.61 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new tagcloud_di_2956677_2.patch8.61 KB

Created a patch.Please reviewed it.

useernamee’s picture

useernamee commented
StatusFileSize
new tagcloud_di_2956677_3.patch11.25 KB
new interdiff_tagcloud_di_2956677_2_3.txt3.13 KB

I have tested patch #2. It applies nicely and works (I just had to reinstall module after applying the patch). After code inspection I found out you missed out two services in class TagcloudsPageChunk. I have injected them too.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

Nice catch @useernamee, tested your patch and it fixes my issues.Marking as RTBC.

asya_asina’s picture

asya_asina commented

The patch applied and working.

andrey.troeglazov’s picture

andrey.troeglazov commented
Assigned: Unassigned » andrey.troeglazov

andrey.troeglazov’s picture

andrey.troeglazov commented
Status: Reviewed & tested by the community » Fixed
andrey.troeglazov’s picture

andrey.troeglazov commented
Issue tags: +TagCloud Release 8.x-1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.