There is a permission configured by the base permission provider for accessing the overview page/collection route, but it's not used at the moment. This means admin users must either be promoted to the "administer profiles" permission, which might be too much and not granular, or denied access to the collection route.

Similar to #2920932: The "Access the shipping methods overview page" permission is unused on Commerce Shipping.

CommentFileSizeAuthor
#9 2956241-profile-overview-9.patch428 bytesbradjones1
#7 2956241-profile-overview-7.patch428 bytesbradjones1
#5 2956241-profile-overview-5.patch409 bytesbradjones1
#4 Screen Shot 2018-03-27 at 6.21.02 PM.png52.12 KBakash.addweb
#4 Screen Shot 2018-03-27 at 6.20.56 PM.png117.58 KBakash.addweb
#2 Error.png10.58 KBakash.addweb
profile-overview.patch415 bytesbradjones1

Comments

bradjones1 created an issue. See original summary.

akash.addweb’s picture

akash.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Error.png10.58 KB

@bradjones1, I tried to check your patch but I'm unable to test it as it throws me an error which shown in the screenshot.

bradjones1’s picture

bradjones1
Primary language English
commented
Status: Needs work » Needs review

@Ronak.addweb that's not an error, and regardless check that you're on -dev instead of a release, possibly.

akash.addweb’s picture

akash.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Screen Shot 2018-03-27 at 6.20.56 PM.png117.58 KB
new Screen Shot 2018-03-27 at 6.21.02 PM.png52.12 KB

@bradjones1, I checked it locally & using simplytest.me also PFA in that I mentioned the screenshots of simplytest.me.

bradjones1’s picture

bradjones1
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2956241-profile-overview-5.patch409 bytes

The fuzz shoudln't result in a patching error but here's an updated one.

Status: Needs review » Needs work

The last submitted patch, 5: 2956241-profile-overview-5.patch, failed testing. View results

bradjones1’s picture

bradjones1
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2956241-profile-overview-7.patch428 bytes

Appeasing the test with an OR permission check.

Status: Needs review » Needs work

The last submitted patch, 7: 2956241-profile-overview-7.patch, failed testing. View results

bradjones1’s picture

bradjones1
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2956241-profile-overview-9.patch428 bytes

Actually OR is +

maaty388’s picture

maaty388 commented
Status: Needs review » Reviewed & tested by the community

I can confirm that patch is working

  • mglaman committed 39504a5 on 8.x-1.x authored by bradjones1 
    Issue #2956241 by bradjones1, Ronak.addweb: Use overview permission for...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.