Dependency injection should be used in ProtectedPagesSubscriber.

CommentFileSizeAuthor
#5 protected_pages_di_event_2956008_5.patch6.92 KBoksana-c
#2 protected_pages_di_event_2956008_2.patch7.23 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new protected_pages_di_event_2956008_2.patch7.23 KB

Created a patch, to use dependency injection in the event subscriber.

useernamee’s picture

useernamee commented
Status: Needs review » Reviewed & tested by the community

I have tested this patch. It applies nicely and it works. I think that all the static calls that could be removed have been.

oksana-c’s picture

oksana-c commented
Version: 8.x-1.0 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Needs work
oksana-c’s picture

oksana-c commented
StatusFileSize
new protected_pages_di_event_2956008_5.patch6.92 KB

  • oksana-c committed 3ea8365 on 8.x-1.x 
    Issue #2956008 by nkoporec, oksana-c, useernamee: Dependency Injection...
oksana-c’s picture

oksana-c commented
Status: Needs work » Fixed
chris matthews’s picture

chris matthews commented
Parent issue: » #3081271: Plan for Protected Pages 8.x-1.2 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.