We should use dependency injection in all forms to stay consistent.

CommentFileSizeAuthor
#6 protected_pages_di_form_2955986_6.patch16.46 KBoksana-c
#2 protected_pages_di_form_2955986_2.patch14.49 KBnkoporec

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: nkoporec » Unassigned
Status: Active » Needs review
StatusFileSize
new protected_pages_di_form_2955986_2.patch14.49 KB

Created a patch which uses dependency injection in all services used in forms.

useernamee’s picture

useernamee commented
Status: Needs review » Reviewed & tested by the community

I have tested your patch @nkoporec. It applies nicely.

oksana-c’s picture

oksana-c commented
Status: Reviewed & tested by the community » Needs work
oksana-c’s picture

oksana-c commented
Version: 8.x-1.0 » 8.x-1.x-dev
oksana-c’s picture

oksana-c commented
StatusFileSize
new protected_pages_di_form_2955986_6.patch16.46 KB

  • oksana-c committed 88fd7cd on 8.x-1.x 
    Issue #2955986 by nkoporec, oksana-c, useernamee: Dependency Injection...
oksana-c’s picture

oksana-c commented
Status: Needs work » Fixed

Updated the patch and committed. Thank you both.

chris matthews’s picture

chris matthews commented
Parent issue: » #3081271: Plan for Protected Pages 8.x-1.2 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.