The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Minor one, just because I ran into this trap today:
This module depends on the core page_cache module, at least with RC1. The dependency should be added to the info.yml file, otherwise it might leave your site unusable if page cache is disabled, throwing weird symfony errors about the missing page.cache service.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | drush_language-remove_unnecessary_dependencies-2955277-5.patch | 4.14 KB | grimreaper |
| #4 | 2955277-remove-unnecessary-dependencies.patch | 3.27 KB | tikaszvince |
| #3 | 2955277_add_missing_dependency-2955277-3.patch | 579 bytes | hiramanpatil |
Comments
Comment #2
hiramanpatilComment #3
hiramanpatilAdded dependency. Please find attached patch.
Comment #4
tikaszvince commentedHi,
I think it would be better solution if this module and DrushLanguageCliService class do not demand dependencies if doesn't use those services at all. My patch removes those unnecessary dependencies.
Comment #5
grimreaperHi,
Encountered this today. Sorry I missed that one in the refactoring of Drush language.
@tikaszvince: Thanks for the patch. I was about to make the same one.
Here is an updated patch because there were two unnecessary use remaining.
Comment #7
geek-merlinUps, that sounds like a real PITA.
@grimreaper Yes i think you should know the code best ;-)
git-am-patch ++!
Released a quick RC2 with this.
Thanks guysngals for cleaning this up!
Comment #8
grimreaper@axel.rutz: Thanks for the merge and the release. :)