Change @param int $stockEvent to $stock_event_id in StockEventsInterface [#2954682]

Sounds minor but its interface, and we should fix this before release.

1) Coding standard requires snack_case for arguments.
2) the method name ist stockEvent. A parameter with the same name hurts my brain.

So I suggest renaming it to $stock_event_id.

As I look into it, i would rename the $transaction_type to $transaction_type_id to. If it is an id, name it as such. Is much easier to understand.

Comments

20 March 2018 at 19:16

olafkarsten commented 20 March 2018 at 19:17

@guy_schneerson tell me what you think and I will do it.

guy_schneerson commented 5 April 2018 at 16:15

$stock_event_id is perfect and happy to rename $transaction_type to $transaction_type_id.

olafkarsten commented 1 June 2018 at 14:00

Priority:

Normal

» Major

bumping up, because it API relevant, therefore needs to be done before beta.

olafkarsten commented 30 January 2020 at 10:58

no more API changes that are not essential for 8.1