https://pareview.sh/ identified two hook_help() implementations as missing:

The password_policy_test.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
The password_policy_password_tab.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .

CommentFileSizeAuthor
#7 password_policy-7.x-2.x-implement_hook_help-2954325-7.patch1.48 KBaohrvetpv
#3 password_policy-7.x-1.x-add_missing_hook_help_implementations-2954325-3.patch1.36 KBaohrvetpv

Comments

AohRveTPV created an issue. See original summary.

aohrvetpv’s picture

aohrvetpv commented

Also applies to 7.x-2.x-dev.

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs review
StatusFileSize
new password_policy-7.x-1.x-add_missing_hook_help_implementations-2954325-3.patch1.36 KB

  • AohRveTPV committed 5f9cc33 on 7.x-1.x 
    Issue #2954325 by AohRveTPV: Missing hook_help() implementations
aohrvetpv’s picture

aohrvetpv commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
aohrvetpv’s picture

aohrvetpv commented
Assigned: Unassigned » aohrvetpv
Status: Needs review » Active

Plan to use the introduction from the new 7.x-2.x README.txt (#2954317: Missing required README.txt sections) for the initial password_policy module hook_help() implementation.

The password_policy_test module can just have a dummy implementation to satisfy PAReview.

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs review
StatusFileSize
new password_policy-7.x-2.x-implement_hook_help-2954325-7.patch1.48 KB

Patch to use README.txt for 7.x-2.x Help module help.

Unfortunately the settings page (admin/config/people/password_policy) does not show up under "Password Policy administration pages" when you go to the module help. This is because the menu item for that page is defined via the Ctools Export UI, not Password Policy itself. Not sure how to get the page to show up there. The location of the settings page is referenced from the README.txt, so maybe it's OK that it's not listed under "Password Policy administration pages".

  • AohRveTPV committed 0d0de5b on 7.x-2.x 
    Issue #2954325 by AohRveTPV: Missing hook_help() implementations
  • AohRveTPV committed c59d8be on 7.x-2.x
    Issue #2954325 by AohRveTPV: Missing hook_help() implementations

  • AohRveTPV committed 4c4e581 on 7.x-2.x 
    Revert "Issue #2954325 by AohRveTPV: Missing hook_help() implementations...
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

Accidentally committed a patch from another issue with the same commit message, hence the reversion of one of the two commits.

aohrvetpv’s picture

aohrvetpv commented
Version: 7.x-2.x-dev » 8.x-3.x-dev
Status: Fixed » Active

8.x-3.x will eventually need one too. Maybe could be postponed since 8.x-3.x is still alpha.

aohrvetpv’s picture

aohrvetpv commented
Version: 8.x-3.x-dev » 7.x-2.x-dev
Status: Active » Fixed

Nevermind, #2948028: Help is missing on module file already exists for 8.x-3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.