Problem/Motivation

When loading the viewreference widgets and getting view names via ViewsReferenceTrait::getViewNames, stale configuration with a configured view that may not actuallky exist resulting in error.

  • Configure viewreference field to only use one view
  • Delete this view
  • Edit the entity that uses this viewreference field and observer error

Proposed resolution

Check for null $view in ViewsReferenceTrait::getViewNames()

Remaining tasks

Patch

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 viewsreference_null-view_2953761-3.patch763 bytesjasonawant
#2 viewsreference_null-view_2953761-2.patch664 bytesjasonawant

Comments

jasonawant created an issue. See original summary.

jasonawant’s picture

jasonawant
he/him
Primary language English
Location New Orleans, USA
commented
Version: 8.x-1.x-dev » 8.x-1.2
Status: Active » Needs review
StatusFileSize
new viewsreference_null-view_2953761-2.patch664 bytes

Here's a patch for this.

jasonawant’s picture

jasonawant
he/him
Primary language English
Location New Orleans, USA
commented
StatusFileSize
new viewsreference_null-view_2953761-3.patch763 bytes

Realized that if there are no views, $views_list will be undefined. New patch

ivan berezhnov’s picture

ivan berezhnov commented

I reviewed and all work correctly. Thank you @jasonawant for fix.

ivan berezhnov’s picture

ivan berezhnov commented
Status: Needs review » Reviewed & tested by the community

  • New Zeal committed eac4c39 on 8.x-1.x authored by jasonawant 
    Issue #2953761 by jasonawant: ViewsReferenceTrait::getViewNames does...
NewZeal’s picture

NewZeal commented
Status: Reviewed & tested by the community » Fixed
NewZeal’s picture

NewZeal commented
Status: Fixed » Closed (fixed)

Deployed into 8.x-1.3