Closed (fixed)
Project:
Recently Read
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2018 at 13:07 UTC
Updated:
4 Apr 2018 at 08:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
nkoporecComment #3
nkoporecCreated a patch which adds a config form where you can select the time period when the cron deletes recently read data.
Comment #4
icurk commentedPatch works great, but I have some comments about it.
1. Configuration link is added with *links.action.yml, which is not the best way to do it. It is better to create configuration link as a tab with *.links.task.yml.
2. In RecentlyReadConfigForm change:
with
There is no configuration object with 'recentlyread.config' name.
3. Fix coding standards in buildForm method of RecentlyReadConfigForm class (replace array() with []).
Comment #5
nkoporecThank you for reviewing my patch.Created a new patch with fixed issues that you have found.
Comment #6
zterry95 commentedone more suggestion:
add cron task to cleanup expire logs.
Comment #7
icurk commented@zterry95 expire logs are already deleted on cron with this patch. The patch looks good.
Comment #9
boshtian commentedGreat work @nkoporec and thanks @icurk for testing.