Please add in the module an opportunity to place fields according to html a pattern and add an opportunity of automatic scaling of pictures in a floor image
here new the module

CommentFileSizeAuthor
#8 flexinodenew02092005.patch16.74 KBkiev1.org
#6 flexinode_new30082005.png120.22 KBkiev1.org
#4 flexinode0820051.diff21.06 KBkiev1.org
#2 flexinode082005.diff31.24 KBkiev1.org
flexinode17082005.zip65.11 KBkiev1.org
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented

please have a look at http://drupal.org/diffandpatch and at http://drupal.org/diff
and send in patches. A zipped file is nearly unusable for developers to track and review.

kiev1.org’s picture

kiev1.org CreditAttribution: kiev1.org commented
FileSize
flexinode082005.diff31.24 KB
Tobias Maier’s picture

Tobias Maier CreditAttribution: Tobias Maier commented

sorry, but this is also not the used patch format
-->diff -u
please look again in the handbook.

if you open the both files later and compare them youll see the one asked from us is much easier to understand.
thanks again :D

kiev1.org’s picture

kiev1.org CreditAttribution: kiev1.org commented
FileSize
flexinode0820051.diff21.06 KB
kiev1.org’s picture

kiev1.org CreditAttribution: kiev1.org commented

screenshot
http://drupal.org/files/issues/flexinode_new30082005.png
So processing of images is added - they now are scaled 2 times thumb and max - by pressing on thumb - jumps out pop-up a window with the big picture

kiev1.org’s picture

kiev1.org CreditAttribution: kiev1.org commented
FileSize
flexinode_new30082005.png120.22 KB

screenshot in attach

So processing of images is added - they now are scaled 2 times thumb and max - by pressing on thumb - jumps out pop-up a window with the big picture

Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented

A first review:
1 use english comments, please :)
2 use proper identation;
3 do not use # for comments. And use proper doxygen comments
4 use correct spacing if () instead of if()

Please also read the drupal coding guidelines.

All in all the feature itself sounds great, just the implementaion is messy. Do not take these comments as plain critique. For the fact it receives so much comments, means people are interested in it.

kiev1.org’s picture

kiev1.org CreditAttribution: kiev1.org commented
FileSize
flexinodenew02092005.patch16.74 KB
Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented

Kiev, please mind your coding style. It is a bit sloppy.
refer to http://drupal.org/node/318 about spacing, tabs, and so on.

And please use english comments. I guess you wrote some Russian.

But most of all, I believe what you have createdshould be made a new .inc file.

Dublin Drupaller’s picture

Dublin Drupaller CreditAttribution: Dublin Drupaller commented

I think the patch idea is superb and I have started a thread where we can discuss and help tidy up the code & language as a group so it's in better shape to submit as a proper patch.

http://drupal.org/node/30376#comment-52101

Hope that makes sense..

Dub