Hi, I'd like to see scripturefilter ported to D8. I worked on and tested a patch locally. I'll post the patch here in a sec, just grabbing an issue # first.

CommentFileSizeAuthor
#2 scripturefilter-port-to-d8.png279.55 KBcodybarr
#2 scripturefilter-port-to-d8-2951697-2.patch7.96 KBcodybarr

Comments

codybarr created an issue. See original summary.

codybarr’s picture

codybarr commented
Component: Supported Scripture Versions » Code
Status: Needs work » Needs review
StatusFileSize
new scripturefilter-port-to-d8-2951697-2.patch7.96 KB
new scripturefilter-port-to-d8.png279.55 KB

Attaching patch. Needs to be reviewed and tested by the community.

Here's a quick screenshot of my basic tests locally though:

patch-example

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented

Just to let you know that I've seen this. Thank you very much for getting things moving.

  • f31a473 committed on 8.x-1.x 
    Issue #2951697 by codybarr, JamesOakley: Initial Drupal 8 port
jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Status: Needs review » Fixed
Related issues: +#2952286: Create configuration migration path from D7 -> D8

I made a few changes

  • Coding standards - indent with two spaces
  • Settings form was always displaying ESV as the default translation even when another translation had been set manually
  • Edited README to remove instructions for those who had just upgraded to Drupal 7
  • Restored filter tip callback

Those are all relatively minor, so a big thank you.

That is now committed and there should be a -dev release once the builder has done its thing.

I'd like to see the configuration for this filter brought into the migration process for anyone bringing a site over from Drupal 7, and at the moment have no idea how to do that. See: #2952286: Create configuration migration path from D7 -> D8

codybarr’s picture

codybarr commented

Awesome. Thanks James.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.