"This value should be of the correct primitive type" error when field has value - no selected

Drupal 8.4.4
PHP 7.0.27

CommentFileSizeAuthor
#2 value_should_be_of_the_correct_primitive_type-2950978-2.patch602 bytessergiu stici

Issue fork starrating-2950978

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

proweb.ua created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
StatusFileSize
new value_should_be_of_the_correct_primitive_type-2950978-2.patch602 bytes
sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
bigmonmulgrew’s picture

bigmonmulgrew commented
Status: Needs review » Reviewed & tested by the community

Tested and working on D9.1.6

alexverb’s picture

alexverb commented

Not a fan. Shouldn't we try to allow null instead of switching to string?

alexverb opened merge request !2

alexverb’s picture

alexverb commented
Status: Reviewed & tested by the community » Needs review

I've created a merge request that uses 0 as the empty_option. This is backwards compatible and doesn't change the property definition's type: https://git.drupalcode.org/project/starrating/-/merge_requests/2/diffs

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Version: 8.x-4.0-alpha2 » 8.x-4.x-dev

  • voleger committed 7cc17de8 on 8.x-4.x authored by alexverb 
    Issue #2950978 by Sergiu Stici: This value should be of the correct...
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs review » Fixed

MR changes make sense. Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.