Hey guys! I've installed and configured the module yesterday, I like all the options it offers out-of-the-box, good job!

Problem/Motivation

After I configured it together with smart_ip module, I noticed that the menu item /eu-cookie-compliance-check (function: eu_cookie_compliance_json) always returns 'in_eu: true'. Using proxy from US, yields this json:

{"country":"US","in_eu":true}

Proposed resolution

The problem happens because the variable $geoip_match is set to TRUE (by default), so it always returns as TRUE.

CommentFileSizeAuthor
#2 eu_cookie_compliance-always_in_eu-2949852-2.patch552 bytesnikro

Comments

Nikro created an issue. See original summary.

nikro’s picture

nikro commented
Status: Active » Needs review
StatusFileSize
new eu_cookie_compliance-always_in_eu-2949852-2.patch552 bytes

So, as I recommended, I submit the patch.
Tested in EU, returns TRUE, tested through US, returns FALSE, now works as expected.

  • svenryen committed a187c9c on 7.x-1.x authored by Nikro 
    Issue #2949852 by Nikro: Menu callback always returns in_eu: true
svenryen’s picture

svenryen commented
Status: Needs review » Fixed

You're absolutely spot on with that! Thanks for the patch, I just committed it.

svenryen’s picture

svenryen commented
Status: Fixed » Closed (fixed)