Closed (outdated)
Project:
Office Hours
Version:
8.x-1.x-dev
Component:
Code - widget
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Mar 2018 at 16:54 UTC
Updated:
7 Apr 2022 at 09:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
zenimagine commentedThe schedule form is not correctly displayed on a small screen.
Can you adapt the table for the responsive ?
Comment #3
johnvA volunteer is greatly appreciated.
Comment #4
janez zibelnik commentedThe following patch makes the parent div scrollable on overflow-x.
Comment #5
zenimagine commentedThank you. I applied the patch but it does not work. The schedule form remains illegible on mobile
Comment #6
janez zibelnik commentedProviding a new patch.
Comment #7
zenimagine commentedI applied the patch but the display and user experience on mobile is not good
Comment #8
vdenis commentedThe following patch fixes help text so that it doesn't go out of the container as can you see on #7 image.
Comment #9
zenimagine commented#8 Thank you, it works.
Can you put the minutes and the hours on a line?
At home, the help text is beyond the block.
Comment #10
vdenis commented@zenimagine I've applied requested changes so that now hours and minutes are in one line when you editing the node.
Please take a look.
Comment #11
zenimagine commentedThank you, I tested the patch and it does not work for me. I use the Bootstrap theme on my site and the display is very bad.
Comment #12
vdenis commentedComment #13
vdenis commentedProviding new patch. @zenimagine, can you please test again?
Comment #14
vdenis commentedComment #15
zenimagine commentedThe responsive does not work
Comment #16
johnvI guess this only applies to the widget, not the formatter.
there is some code replicated 4 times, that could be encapsulated into a function.
Comment #17
scottsawyerI have been thinking about this, and I wonder if it might be better solved by replacing the table markup entirely?
My initial thoughts would be to do something like this: ( sort of abbreviated, but a lot of markup, sorry )
My CSS probably needs some work ( also, maybe grid is a better solution than flexbox ), but the general idea would be the columns would simply start wrapping as the screen gets smaller. I think the CSS would be way simpler than the CSS + JS implementation in the patch, plus, it wouldn't depend on arbitrary breakpoints that may have nothing to do with what the site builder / themer wants.
Comment #18
zenimagine commentedit would be nice if the next update is finally in responsive design.
Currently this module is not usable on smartphone.
Comment #19
zenimagine commentedThis problem should be addressed first
Comment #20
zenimagine commented@scottsawyer In which templates should you put this code ?
Comment #21
scottsawyerHonestly, I did not even look at the templates, I just looked at the rendered markup and thought about how I might improve it.
Comment #22
zenimagine commented@scottsawyer would you have screenshot of the code rendering? on pc and smartphone
Comment #23
scottsawyerI just did this in my browser's dev tools. Needs some work. This is a custom admin theme.
Comment #24
zenimagine commentedit looks good, but you have to remove the panels
Comment #25
zenimagine commentedHi guys, there is an urgent need to deal with this problem.
The template to display the schedules in the form is disastrous. We really have to deal with the problem of responsive design. The schedules are unusable on the desktop when there are error messages and it is even worse on mobile.
Comment #26
matija5 commentedOffice hour week table in form can be made responsive with a little css.
But I think new widget should be created and make it responsive.
Comment #27
matija5 commentedResponsive table form with grid css. Tested with Seven and Claro theme.
Comment #28
zenimagine commentedWith the Bootstrap theme on mobile the form is unusable. All of my users must use a desktop computer if they want to create a store or group. Even on a tablet, the picture looks like nothing. This problem should be dealt with as a priority.
Comment #29
zenimagine commentedComment #30
johnvPlease be aware that #3102097: Make Widget Help text responsive was committed, doing half the trick.
Comment #31
johnvGiven the current state of the Widget (with many UX fixes from other issues), I guess this ticket can be closed.
Please reopen if you feel otherwise.