Missing dependencies

Here is the fix for "node" part.

The Shortcut module is also missing as a dependency leading to problems on admin pages if that module is not enabled.

Here is a first patch that adds the missing dependency on the Shortcut module. I'm not sure about other missing dependencies so please extend the patch to complete it.

Thank you for the patch took me a while to track down that this module requires shortcut which I do not have enabled and everytime I would clear the cache I would get a user warning that the shortcut theme was missing such as:

User warning: The following theme is missing from the file system: shortcut in drupal_get_filename() (line 269 of core/includes/bootstrap.inc).

drupal_get_filename('theme', 'shortcut') (Line: 292)
drupal_get_path('theme', 'shortcut') (Line: 394)
Drupal\Core\Asset\LibraryDiscoveryParser->drupalGetPath('theme', 'shortcut') (Line: 85)
Drupal\Core\Asset\LibraryDiscoveryParser->buildByExtension('shortcut') (Line: 87)
Drupal\Core\Asset\LibraryDiscoveryCollector->getLibraryDefinitions('shortcut') (Line: 66)
Drupal\Core\Asset\LibraryDiscoveryCollector->resolveCacheMiss('shortcut') (Line: 149)
Drupal\Core\Cache\CacheCollector->get('shortcut') (Line: 44)
Drupal\Core\Asset\LibraryDiscovery->getLibrariesByExtension('shortcut') (Line: 58)
Drupal\Core\Asset\LibraryDiscovery->getLibraryByName('shortcut', 'drupal.shortcut') (Line: 54)
Drupal\Core\Asset\LibraryDependencyResolver->doGetDependencies(Array) (Line: 31)
Drupal\Core\Asset\LibraryDependencyResolver->getLibrariesWithDependencies(Array) (Line: 104)
Drupal\Core\Asset\AssetResolver->getLibrariesToLoad(Object) (Line: 116)
Drupal\Core\Asset\AssetResolver->getCssAssets(Object, ) (Line: 291)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAssetLibraries(Object, Array) (Line: 161)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAttachments(Object) (Line: 94)
Drupal\big_pipe\Render\BigPipeResponseAttachmentsProcessor->processAttachments(Object) (Line: 45)
Drupal\Core\EventSubscriber\HtmlResponseSubscriber->onRespond(Object, 'kernel.response', Object)
call_user_func(Array, Object, 'kernel.response', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.response', Object) (Line: 191)
Symfony\Component\HttpKernel\HttpKernel->filterResponse(Object, Object, 1) (Line: 173)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 100)
Drupal\cleanpager\StackMiddleware\CleanPager->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 664)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I myself would prefer to not have to use the shortcut module at all and would like to see this handled differently.

My Two Cents.

Added dependencies:

• GDPR Tasks requires views and options
• GDPR Consent requires views

Removed unneeded dependencies:

• Shortcut is not needed, we should add custom toolbar icons

Moving issue state manually from Fixed 🠂 to Closed (fixed) in the hope that issue queue gets cleaner a bit.