Notice: Undefined index: source_type in webform_conditional_element_add()

This may be a duplicate of #2842513: Undefined index: operator in _webform_conditional_expand().

@Liam Morland, Please find this patch to resolve the above-mentioned patch, I received it in the AJAX when installing the module.

Why is empty() changed to !empty()?

With this patch, $new[0] is not set if $parent_values[$rid]['source_type'] is not set, rather than getting $default_rule. Is that intentional?

@Liam Morland, Thanks for reviewing my patch, I updated it again. Kindly review it & let me know if any further change is required. Thanks!..

Can you answer the second question in #4?

@Liam Morland, good question, it's probably not intentional. $new[0] is however set in the else block but not to the $default_rule.

I can't really follow the logic myself so not sure which is correct, maybe you know?

I don't know what it is supposed to be like. For fixing undefined index errors, I hesitate to make any changes in how it works unless I am sure it is actually a bug.

Does this solve it for you? This shouldn't have any effect on the functionality.

This may have been resolved in #2842513: Undefined index: operator in _webform_conditional_expand(). Have you reproduced the issue on 7.x-4.18?

I've seen it recently (Nov 6th in 7.x-4.18), that looks like it would fix the notice without changing how it works, thanks @Liam Morland.

Thanks everyone!