Hello,

The config schema for a cluster and a search api index are wrong.

I will upload a patch soon.

CommentFileSizeAuthor
#3 elasticsearch_connector-fix-config-schema-2948745-03--interdiff.patch3.62 KBjedihe
#3 elasticsearch_connector-fix-config-schema-2948745-03.patch4.29 KBjedihe
#3 elasticsearch_connector-fix-config-schema-2948745-03--tests-only.patch1.89 KBjedihe
#2 elasticsearch_connector-fix_config_schema-2948745-2.patch2.17 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
StatusFileSize
new elasticsearch_connector-fix_config_schema-2948745-2.patch2.17 KB

Here is the patch.

Thanks for the review.

jedihe’s picture

jedihe commented
Version: 8.x-5.0-alpha2 » 8.x-7.x-dev
StatusFileSize
new elasticsearch_connector-fix-config-schema-2948745-03--tests-only.patch1.89 KB
new elasticsearch_connector-fix-config-schema-2948745-03.patch4.29 KB
new elasticsearch_connector-fix-config-schema-2948745-03--interdiff.patch3.62 KB

Just worked on this one (in 8.x-7.x), adding a kernel test to validate the config schema for the cluster entity; the test covers the recent work at #3010955: Allow index name flexibility.

I didn't test the change done to elasticsearch_connector.backend.schema.yml by @Grimreaper, though.

jedihe’s picture

jedihe commented
Title: Fix config schema » Fix config schema + add tests
bartlangelaan’s picture

bartlangelaan
Primary language Dutch
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Works great! Thanks!

  • sokru committed 50c728e8 on 8.x-7.x authored by jedihe 
    Issue #2948745 by jedihe, Grimreaper, bartlangelaan: Fix config schema...
sokru’s picture

sokru commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.