Hello,

The config schema is incorrect.

I will upload a patch soon.

CommentFileSizeAuthor
#4 fontawesome_menu_icons-fix_config_schema-2948734-4.patch434 bytesbandanasharma
#3 label-quotations.png6.39 KBbandanasharma
#2 fontawesome_menu_icons-fix_config_schema-2948734-2.patch758 bytesgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
StatusFileSize
new fontawesome_menu_icons-fix_config_schema-2948734-2.patch758 bytes

Here is the patch.

Thanks for the review.

bandanasharma’s picture

bandanasharma commented
Status: Needs review » Needs work
StatusFileSize
new label-quotations.png6.39 KB

@Grimreaper patch apply successfully. Changes reflect on file but according to configuration-schema metadata documentation label should be wrap in single quotations marks. See the attached screen shot.

bandanasharma’s picture

bandanasharma commented
Status: Needs work » Needs review
StatusFileSize
new fontawesome_menu_icons-fix_config_schema-2948734-4.patch434 bytes

Wrap the label into single quotations marks and upload the patch.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Reviewed & tested by the community

@bandanasharma, thanks for testing the patch.

Yes, the label has a coding standard minor violation, but the goal of my original patch was to fix the "type" key not the "label" key.

Changing status to RTBC as you have tested it.

lonalore’s picture

lonalore
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.