On README.md file, the link pointing to the configuration is wrong.

Wrong: /admin/config/security/password/settings
Right: /admin/config/security/password-policy

CommentFileSizeAuthor
#5 readme_2948046_5.patch463 bytesemartoni
#3 help_2948028_3.patch3.44 KBemartoni

Comments

emartoni created an issue. See original summary.

emartoni’s picture

emartoni commented
Assigned: Unassigned » emartoni

Working on it!

emartoni’s picture

emartoni commented
Assigned: emartoni » Unassigned
Status: Active » Needs review
StatusFileSize
new help_2948028_3.patch3.44 KB

Patch attached!

Best,
Eduardo

chrisdarke’s picture

chrisdarke commented
Status: Needs review » Needs work

Hi Eduardo,
This looks great, just a couple of items:

1. modules/password_policy/password_policy.module:430 - maybe rephrase as 'Enable the module via drush or the Extend page'?
2. modules/password_policy/password_policy.module:438 - rename link to 'Zxcvbn Plugin'
3. the original erroneous link in the README.md was never corrected.

Other than that, good!

emartoni’s picture

emartoni commented
Status: Needs work » Needs review
Related issues: +#2948028: Help is missing on module file
StatusFileSize
new readme_2948046_5.patch463 bytes

Hi @ChrisDarke, how are you?

My bad. I attached the wrong patch.
Attached the right one now.

The missing help is another issue (also I applied the proposed fix on it).

chrisdarke’s picture

chrisdarke commented
Status: Needs review » Reviewed & tested by the community

Haha I should have noticed the wrong patch number on the file! Just figured you were tidying up by adding the help function at the same time, and missed the original fix!

Patch looks good.

  • AohRveTPV committed 2c9ea4d on 8.x-3.x authored by emartoni 
    Issue #2948046 by emartoni: Configuration link is wrong on README.md
aohrvetpv’s picture

aohrvetpv commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.