Problem

There is no schema declaration for the social_comment.comment_settings config object.

Proposed solution

Add a config/schema/social_comment.schema.yml file with the following contents:

social_comment.comment_settings:
  type: config_object
  label: 'Social Comment Settings'
  mapping:
    redirect_comment_to_entity:
      type: boolean
      label: 'Redirect a comment view to its parent entity'

Needed discussion

Discuss whether the labels/descriptions are correct.

CommentFileSizeAuthor
#5 2947902_5.patch435 bytesemartoni

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

Issue summary: View changes

Fix typo

kingdutch’s picture

Issue tags: +Novice
emartoni’s picture

Assigned: Unassigned » emartoni

working on it

emartoni’s picture

Assigned: emartoni » Unassigned
Status: Active » Needs review
StatusFileSize
new435 bytes

Patch attached!

Best,
Eduardo

kingdutch’s picture

Status: Needs review » Reviewed & tested by the community

Pull request for this has been created here: https://github.com/goalgorilla/open_social/pull/759

jaapjan’s picture

Status: Reviewed & tested by the community » Fixed

Thanks all!

jaapjan’s picture

  • Kingdutch committed 0bf260b on 8.x-2.x
    Issue #2947902 by emartoni, Kingdutch: Missing schema for social_comment...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.