Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I would have re-opened #2941285: Broken relative marker icon path but it's now locked, forcing me to open a new issue...
Although that issue and commit 5dd97c79ef5f might have been an improvement for custom marker icons, the default icons no longer work. ;) I just upgrade a test site to the latest code in 8.x-1.x-dev (commit 3364ed6a2b1) and all of a sudden all my geolocation Google maps are missing their markers. I was never using any custom markers, simply relying on the default. I reverted commit 5dd97c7 and the default markers are back and working again.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2947648-2.geolocation-fix-default-marker-icon-path.patch | 965 bytes | dww |
| |||
Comments
Comment #2
dwwI don't completely understand what #2941285 was trying to fix, but I believe the attached patch should preserve that functionality while still letting the default markers work. Basically, we only do the whole token replacement and file_create_url() et al if there's a custom icon path defined. Otherwise, we leave everything blank, which allows the default marker icon to be used.
Comment #4
ChristianAdamski CreditAttribution: ChristianAdamski commentedFair enough
Comment #5
ChristianAdamski CreditAttribution: ChristianAdamski commentedCheck 8.2.x
Comment #6
ChristianAdamski CreditAttribution: ChristianAdamski commented8.2.x seems not affected due to entirely different structure
Comment #7
dwwThanks for the quick fix!
Cheers,
-Derek