"uid" entity key is missing in Profile annotation

This makes sense to me. This is exactly how the node module handles the uid base field.

I'm not 100% sure about this step, but the node module also wrote an update hook to ensure the uid field was added to the field storage definition - http://cgit.drupalcode.org/drupal/tree/core/modules/node/node.install#n195.

In the spirit of that, I've added an update hook to the patch which performs the same operations for adding the uid to the entity_keys of the profile module.

Feedback welcome

+++ b/profile.install
@@ -54,3 +54,17 @@ function profile_update_8002() {
+
+/**
+ * Add uid to profile entity_keys.
+ */
+function profile_update_8003() {
...
+  $manager = \Drupal::entityDefinitionUpdateManager();
+  $entity_type = $manager->getEntityType('profile');
+  $entity_keys = $entity_type->getKeys();
+  $entity_keys['uid'] = 'uid';
+  $entity_type->set('entity_keys', $entity_keys);
+  $manager->updateEntityType($entity_type);
+  $manager->updateFieldStorageDefinition($manager->getFieldStorageDefinition('uid', 'profile'));
+}

I'm not sure why this is needed, we already have the field available.

Looking at that update function.. now I see:

  // @todo The above should be enough, since that is the only definition that
  //   changed. But \Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema varies
  //   field schema by whether a field is an entity key, so invoke
  //   EntityDefinitionUpdateManagerInterface::updateFieldStorageDefinition()
  //   with an unmodified field storage definition to trigger the necessary
  //   changes. SqlContentEntityStorageSchema::onEntityTypeUpdate() should be
  //   fixed to automatically handle this.

Apparently that line of code is still valid #2981915: Update MenuLinkContent to use EntityPublishedInterface

	+/**
+ * Add the publishing status entity key to custom menu links.
+ */
+function menu_link_content_update_8601() {
+  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();
+  $entity_type = $definition_update_manager->getEntityType('menu_link_content');
+
+  // Add the published entity key to the menu_link_content entity type.
+  $entity_keys = $entity_type->getKeys();
+  $entity_keys['published'] = 'enabled';
+  $entity_type->set('entity_keys', $entity_keys);
+  $definition_update_manager->updateEntityType($entity_type);
+
+  // @todo The above should be enough, since that is the only definition that
+  //   changed. But \Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema varies
+  //   field schema by whether a field is an entity key, so invoke
+  //   EntityDefinitionUpdateManagerInterface::updateFieldStorageDefinition()
+  //   with an unmodified field storage definition to trigger the necessary
+  //   changes. SqlContentEntityStorageSchema::onEntityTypeUpdate() should be
+  //   fixed to automatically handle this.
+  //   @see https://www.drupal.org/node/2554245
+  $definition_update_manager->updateFieldStorageDefinition($definition_update_manager->getFieldStorageDefinition('enabled', 'menu_link_content'));
+
+  return t('The publishing status entity key has been added to custom menu links.');
+}

No longer applies, working on a reroll

Reroll!

Okay, only HEAD failure failed.

This also needs to set the "owner" key, like Commerce did, since that is the 8.7 convention.

Thanks @bojanz

Adds owner key alongside legacy uid.

Anddddd committed!

Looks like "menu_link_content" was copy-pasted and not changed. See you in #3038445: Unable to update entity from RC-2?