Attempt to autostart chromedriver for selenium tests

Right now the chromedriver on JS is installed using the package.json. I'm wondering whether we could leverage that somehow too.

1. +++ b/core/.env.example
   @@ -0,0 +1,29 @@
   +# This is a dotenv file used by JavaScript tasks.
   

   I'm curious, should we adapt some of this documentation to point more towards phpunit based testing as well?

2. +++ b/core/.gitignore
   @@ -9,3 +9,5 @@ phpunit.xml
   diff --git a/core/composer.json b/core/composer.json
   
   diff --git a/core/composer.json b/core/composer.json
   index 62e765947d..8f575e94e9 100644
   
   index 62e765947d..8f575e94e9 100644
   --- a/core/composer.json
   
   --- a/core/composer.json
   +++ b/core/composer.json
   
   +++ b/core/composer.json
   +++ b/core/composer.json
   @@ -62,7 +62,8 @@
   
   @@ -62,7 +62,8 @@
            "phpspec/prophecy": "^1.4",
            "symfony/css-selector": "^3.4.0",
            "symfony/phpunit-bridge": "^3.4.3",
   -        "symfony/debug": "^3.4.0"
   +        "symfony/debug": "^3.4.0",
   +        "symfony/dotenv": "^3.4.0"
        },
        "replace": {
            "drupal/action": "self.version",
   

   Can we have a composer script for this?

3. +++ b/core/scripts/php-test.php
   @@ -0,0 +1,22 @@
   +/**
   + * @file
   + * A command line application to install drupal for tests.
   + */
   +
   +use Drupal\PhpTestRunner\PhpTestRunnerApplication;
   

   I'm curious whether we could have the same entry point for all tests, basically run-tests.sh 2.0?

4. +++ b/core/scripts/php-test.php
   @@ -0,0 +1,22 @@
   +$app = new PhpTestRunnerApplication('test-site', '0.1.0');
   

   Note: We should update the name

5. +++ b/core/tests/Drupal/PhpTestRunner/Commands/RunPhpUnitCommand.php
   @@ -0,0 +1,170 @@
   +/**
   + * Command to run Drupal's PHPUnit tests.
   + *
   + * This starts up a webserver and chromedriver as required ensuring tests can
   + * be run with zero configuration.
   + *
   + * @internal
   + */
   +class RunPhpUnitCommand extends Command {
   

   We should document that for more advanced needs you might should run it directly still. One more advanced usage would be to actually run the entire test suite.

6. +++ b/core/tests/Drupal/PhpTestRunner/Commands/RunPhpUnitCommand.php
   @@ -0,0 +1,170 @@
   +  protected $webserver;
   ...
   +  protected $chromedriver;
   

   What about using $webserverProcess and $chromedriverProcess as name?

7. +++ b/core/tests/Drupal/PhpTestRunner/Commands/RunPhpUnitCommand.php
   @@ -0,0 +1,170 @@
   +      ->setHelp('@todo')
   

   I think this help text should point to Phpunit documentation

8. +++ b/core/tests/Drupal/PhpTestRunner/Commands/RunPhpUnitCommand.php
   @@ -0,0 +1,170 @@
   +    $tests = implode(' ', $input->getArgument('test'));
   +    $command = "./vendor/bin/phpunit --verbose -c ./core $tests";
   

   It is nice that you support multiple arguments.

9. +++ b/core/tests/Drupal/PhpTestRunner/Commands/RunPhpUnitCommand.php
   @@ -0,0 +1,170 @@
   +    if ($web_user = getenv('DRUPAL_TEST_WEBSERVER_USER')) {
   +      $command = "sudo -u $web_user $command";
   +    }
   

   What a nice idea ;)

10. +++ b/core/tests/Drupal/PhpTestRunner/PhpTestRunnerApplication.php
    @@ -0,0 +1,28 @@
    +class PhpTestRunnerApplication extends Application {
    +
    +  /**
    +   * {@inheritdoc}
    +   */
    +  protected function getDefaultCommands() {
    +    // Even though this is a single command, keep the HelpCommand (--help).
    +    $default_commands = parent::getDefaultCommands();
    +    $default_commands[] = new RunPhpUnitCommand();
    +    return $default_commands;
    +  }
    +
    

    So if we know there will be just one command anyway, could we skip having a custom class and wire it up in the main entry point?

I was also thinking we could implement a phpunit-other-args option to pass more options on to phpunit if people want.

Let's open up a followup for that?

Re #12.3 - I think there is value using PHP to run PHP tests and JS to run JS tests. Not sure we want a single runner. It also makes it simple just to pass things through to PHPUnit. This doesn't attempt to pass things to run-tests.sh to run Simpletest tests for example.

Fair point. To be honest having composer run-script tests and npm run tests would be enough of consistency for me.

+++ b/core/tests/Drupal/PhpTestRunner/PhpTestRunnerCommand.php
@@ -0,0 +1,209 @@
+    $env = $this->handleEnvironment($input);
+
+    if ($this->webserverProcess) {
+      $output->writeln('<info>Starting PHP webserver</info>');
+      $this->webserverProcess->start();
+    }
+    if ($this->chromedriverProcess) {
+      $output->writeln('<info>Starting Chromedriver</info>');
+      $this->chromedriverProcess->start();
+    }

I'm wondering: Should we check somehow whether we run unit tests and in that case not try to start up a webserver/chromedriver, given that both might be quite slow?