Due to various API changes in TFA, the tests in this module need to be adjusted to allow them to pass.

CommentFileSizeAuthor
#3 2946239-3.patch925 bytesdaggerhart
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daggerhart created an issue. See original summary.

daggerhart’s picture

daggerhart CreditAttribution: daggerhart commented
Title: Fix ga_login simpletests » Fix ga_login simpletests for the purpose of releasing 1.0-alpha3
Issue summary: View changes
daggerhart’s picture

daggerhart CreditAttribution: daggerhart commented
Status: Active » Needs review
FileSize
2946239-3.patch925 bytes

It appears the issue was related to #2930590: Review access requirements and #2937043: Add test_dependencies: to ga_login.info.yml.

Since tfa 1.0-alpha3 was released with the node module as a dependency ('access content' permission required on the EntryForm), this module needs to continue to require it in tests.

We have committed the removal of the node module dependency to the tfa 8.x-1.x branch, but it has not been released yet.

This patch re-adds the node module as a dependency to the simpletests.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Status: Needs review » Fixed

Merging, as the testbot shows the tests are now green.

  • nerdstein committed 457d44a on 8.x-1.x authored by daggerhart 
    Issue #2946239 by daggerhart: Fix ga_login simpletests for the purpose...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.