Dear maintainer,

I'm not a developer so I cannot give more information than the following, hope this might help.

Drupal 7.56. The language dropdown block offered by lang_dropdown with plugin ms-Dropdown stopped to work properly after updating lang_dropdown 7.x-2.5 to 2.6. No icon is shown and the links are hidden, but they work. (See broken.png.)

Downgrading to lang_dropdown 2.5 to 2.6 fixed the problem for me (see fixed.png). I report how to do this with drush 8 in case somebody is in the same situation.
drush pm-disable lang_dropdown
drush pm-download lang_dropdown-7.x-2.5
drush pm-enable lang_dropdown
drush pm-updatestatus --lock=lang_dropdown

Best,
ric

CommentFileSizeAuthor
#3 ms-Dropdown_broken-2944484-3.patch893 bytescosolom
fixed.png2.45 KBr.ductor
broken.png1.26 KBr.ductor

Comments

r.ductor created an issue. See original summary.

pendaco’s picture

pendaco commented

Same issue here with ms-dropdown. Downgrading to 2.5 fixes the issue for now.

For some reason the images from language icons are not loaded. There are no <img> tags in the drop-down html after upgrading.

cosolom’s picture

cosolom commented
StatusFileSize
new ms-Dropdown_broken-2944484-3.patch893 bytes

Try this patch. You will see "Enable language icons" when ms-Dropdown selected. And after check this you will see flags in dropdown

cosolom’s picture

cosolom commented
Status: Active » Needs review
samvel’s picture

samvel commented
Version: 7.x-2.6 » 7.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

Hi guys, I reviewed your patch. It's working fine. I also tried to understand why you not used flag position, but seems it's msDropdown doesn't support this, so we should skip this functionality in our case.

RTBC from me.

pendaco’s picture

pendaco commented

The patch doesn't seem to work for me.

In the 'Language switcher dropdown (User interface text)' block I get the following notices;

Notice: Use of undefined constant LANG_DROPDOWN_SIMPLE_SELECT - assumed 'LANG_DROPDOWN_SIMPLE_SELECT' in lang_dropdown_block_configure() (line 263 of /modules/lang_dropdown/lang_dropdown.module).
Notice: Use of undefined constant LANG_DROPDOWN_CHOSEN - assumed 'LANG_DROPDOWN_CHOSEN' in lang_dropdown_block_configure() (line 264 of /modules/lang_dropdown/lang_dropdown.module).
Notice: Use of undefined constant LANG_DROPDOWN_MSDROPDOWN - assumed 'LANG_DROPDOWN_MSDROPDOWN' in lang_dropdown_block_configure() (line 265 of /modules/lang_dropdown/lang_dropdown.module).

Shouldn't those constants be;

LANGDROPDOWN_SIMPLE_SELECT
LANGDROPDOWN_CHOSEN
LANGDROPDOWN_MSDROPDOWN

Without the additional underscore between LANG and DROPDOWN?

Aside from that I don't get the 'Enable language icons' option for MS Dropdown. I only get that option with Simple Select and Chosen.

cosolom’s picture

cosolom commented

@pendaco do you use latest dev version?

pendaco’s picture

pendaco commented

Aha okay, good one ;) I was applying this to 2.6. Using the dev version fixed the issue and gives me the proper options without any errors/notices.

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: Unassigned » kala4ek

  • kala4ek committed e49169d on 7.x-2.x authored by cosolom 
    Issue #2944484 by cosolom, r.ductor, Samvel, kala4ek: 7.x-2.5 ->2.6 with...
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: kala4ek » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.