Code uses the coalesce operator (??) in \lang_dropdown\src\Plugin\Block\LanguageDropdownBlock.php line 554 and \lang_dropdown\src\Form\LanguageDropdownForm.php line 214. Operator is not compatible w PHP 5.x. Needs to be switched to the ternary operator for PHP 5.x compatibility.

CommentFileSizeAuthor
#2 2944003-removing-php7-code.patch1.68 KBammar qala

Comments

JasonSafro created an issue. See original summary.

ammar qala’s picture

ammar qala commented
StatusFileSize
new 2944003-removing-php7-code.patch1.68 KB

I replaced the "coalescing operator" to "ternary operator" in both "src/Plugin/Block/LanguageDropdownBlock.php" and "src/Form/LanguageDropdownForm.php".

kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Assigned: Unassigned » kala4ek
Status: Active » Needs review
Related issues: +#2942099: After last update, site broken displaying a blank page

Status: Needs review » Needs work

The last submitted patch, 2: 2944003-removing-php7-code.patch, failed testing. View results

  • kala4ek committed 0e49da3 on 8.x-2.x 
    Issue #2944003 by a.qala, kala4ek: Coalesce Operator Not Compatable w...
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
Version: 8.x-2.0-beta2 » 8.x-2.x-dev
Assigned: kala4ek » Unassigned
Status: Needs work » Fixed

?? operators replaced by usual ternary operators.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.